Core: declare scss exports in package #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+27
to
+28
| "./scss/global-styles": "./scss/_global-styles.scss", | ||
| "./scss/utils": "./scss/_utils.scss", |
There was a problem hiding this comment.
Could also be wildcard export to avoid an error in the future, but that would mean we expose all our scss partials as part of our public package, so that would probably be a bit much 🤔
"./scss/*": {
"sass": "./scss/_*.scss"
},
There was a problem hiding this comment.
Yes, let's keep it as explicit exports 👍🏻
github-actions
bot
temporarily deployed
to
pr-core-package-scss-exports
jakobe
approved these changes
Oct 14, 2024
This was referenced Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes an issue with missing scss exports from our core package, resulting in the following error when compiling the designsystem package in projects:
What is the new behavior?
The package exports field in the badge as web comp PR does not include the utils and global_styles scss partials that were previously exported by default.
They are now added as explicit exports.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.